Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Order data with Harmony instead of ECS #554

Closed
wants to merge 12 commits into from
Closed

[WIP] Order data with Harmony instead of ECS #554

wants to merge 12 commits into from

Conversation

mfisher87
Copy link
Member

I'm starting out by adding a Mypy config that has no errors. Then I'm going to add some types to reflect the ECS API requests, and get the type checking passing with that. Then I'll migrate to a new set of Harmony query types.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 13, 2024 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit e30dd35

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit abb6338

Binder 👈 Launch a binder notebook on this branch for commit 41cd95a

Binder 👈 Launch a binder notebook on this branch for commit e79c450

Binder 👈 Launch a binder notebook on this branch for commit 5dd81c8

Binder 👈 Launch a binder notebook on this branch for commit 6e22466

Binder 👈 Launch a binder notebook on this branch for commit 4697ed6

Binder 👈 Launch a binder notebook on this branch for commit ef386a6

Binder 👈 Launch a binder notebook on this branch for commit 78459ef

Binder 👈 Launch a binder notebook on this branch for commit 3fcc23e

Binder 👈 Launch a binder notebook on this branch for commit 9f97442

Binder 👈 Launch a binder notebook on this branch for commit fadcb29

@mfisher87 mfisher87 force-pushed the order-with-harmony branch 3 times, most recently from 41cd95a to e79c450 Compare August 13, 2024 02:04
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.48148% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.84%. Comparing base (817175b) to head (fadcb29).

Files with missing lines Patch % Lines
icepyx/core/granules.py 50.00% 7 Missing ⚠️
icepyx/core/query.py 66.66% 4 Missing ⚠️
icepyx/core/APIformatting.py 85.71% 0 Missing and 3 partials ⚠️
icepyx/core/is2ref.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v2     #554      +/-   ##
==========================================
+ Coverage   65.37%   65.84%   +0.47%     
==========================================
  Files          36       38       +2     
  Lines        3038     3089      +51     
  Branches      531      534       +3     
==========================================
+ Hits         1986     2034      +48     
- Misses        970      971       +1     
- Partials       82       84       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisher87
Copy link
Member Author

I'm going to break this up in smaller pieces.

@mfisher87 mfisher87 closed this Aug 30, 2024
@mfisher87 mfisher87 deleted the order-with-harmony branch August 30, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfisher87